Fix: -Wformat for tc_printf #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HrMitrev
force-pushed
the
wformat
branch
2 times, most recently
from
1169229
to
8af2037
Compare
HrMitrev
commented
May 19, 2024
HrMitrev
commented
May 19, 2024
HrMitrev
commented
May 19, 2024
HrMitrev
commented
May 19, 2024
HrMitrev
commented
May 20, 2024
HrMitrev
commented
May 20, 2024
dragonmux
requested changes
Jun 3, 2024
There was a problem hiding this comment.
We've got just the one review item - nice work! With that addressed, we think this will be ready for merge.
Our only other request is a tweak to the commit message - because it touches so much of the code base, please use the suffix misc: , as in misc: Fixes for tc_printf invocations to enable -Wformat
|
Just a note that, once the remaining review notes have been taken care of, we're happy for this PR to be merged if it could be rebased on |
dragonmux
previously approved these changes
Aug 14, 2024
Signed-off-by: Hristo Mitrev <[email protected]>
dragonmux
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Your checklist for this pull request
Closing issues
#1676